Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clearing cell fields before comparing #24

Merged
merged 1 commit into from
Jan 22, 2022

Conversation

murilo-cunha
Copy link
Member

needed to remove metadata such as id that would make every cell be different

…such as `id` that would make every cell be different
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #24 (080c7ab) into main (c36dbbd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   95.67%   95.70%   +0.03%     
==========================================
  Files          18       18              
  Lines         763      769       +6     
==========================================
+ Hits          730      736       +6     
  Misses         33       33              
Impacted Files Coverage Δ
databooks/conflicts.py 90.00% <100.00%> (+1.11%) ⬆️
tests/test_cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36dbbd...080c7ab. Read the comment docs.

@murilo-cunha murilo-cunha merged commit 24152c5 into main Jan 22, 2022
@murilo-cunha murilo-cunha deleted the bugfix/cell-fields-ignore branch January 22, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant