Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich tables #59

Merged
merged 6 commits into from
Nov 11, 2022
Merged

Add rich tables #59

merged 6 commits into from
Nov 11, 2022

Conversation

murilo-cunha
Copy link
Member

Add rich table (HTML) rendering to notebook.

  • Other HTML elements are not displayed.
  • Fall back to displaying text if that's the case
  • Refactor logic to simplify this
  • Refactor logic to gracefully show not supported mime types (anything that is not one of image/png, text/html, text/plain

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #59 (c9b46a4) into main (1d8cdb7) will decrease coverage by 0.15%.
The diff coverage is 92.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   96.37%   96.21%   -0.16%     
==========================================
  Files          26       28       +2     
  Lines        1433     1481      +48     
==========================================
+ Hits         1381     1425      +44     
- Misses         52       56       +4     
Impacted Files Coverage Δ
databooks/data_models/rich_helpers.py 90.69% <90.69%> (ø)
databooks/data_models/cell.py 95.34% <100.00%> (ø)
tests/test_cli.py 100.00% <100.00%> (ø)
tests/test_data_models/test_rich_helpers.py 100.00% <100.00%> (ø)
tests/test_tui.py 100.00% <100.00%> (ø)

@murilo-cunha murilo-cunha merged commit eeb84c7 into main Nov 11, 2022
@murilo-cunha murilo-cunha deleted the add-rich-tables branch November 11, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant