Skip to content

Commit

Permalink
added checkstyle
Browse files Browse the repository at this point in the history
  • Loading branch information
epalace committed Feb 24, 2012
1 parent d18d08f commit 682de05
Show file tree
Hide file tree
Showing 3 changed files with 64 additions and 6 deletions.
59 changes: 59 additions & 0 deletions checkstyle.xml
@@ -0,0 +1,59 @@
<?xml version="1.0"?>

<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->

<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.2//EN"
"http://www.puppycrawl.com/dtds/configuration_1_2.dtd">

<module name="Checker">
<module name="FileTabCharacter"/>
<module name="NewlineAtEndOfFile">
<property name="lineSeparator" value="lf"/>
</module>

<module name="TreeWalker">
<module name="ConstantName"/>
<module name="LocalFinalVariableName"/>
<module name="LocalVariableName"/>
<module name="MemberName"/>
<module name="MethodName"/>
<module name="PackageName"/>
<module name="ParameterName"/>
<module name="StaticVariableName"/>
<module name="TypeName"/>

<module name="AvoidStarImport"/>
<module name="RedundantImport"/>
<module name="UnusedImports"/>

<module name="RedundantModifier"/>

<module name="EmptyStatement"/>
<module name="IllegalInstantiation"/>
<module name="RedundantThrows"/>
<module name="SimplifyBooleanExpression"/>
<module name="SimplifyBooleanReturn"/>

<module name="InterfaceIsType"/>

<module name="ArrayTypeStyle"/>
<module name="UpperEll"/>

</module>
</module>
Expand Up @@ -44,14 +44,13 @@ public class ProxyOutputFormat extends FileOutputFormat implements Configurable

public final static String PROXIED_OUTPUT_FORMAT_CONF = ProxyOutputFormat.class.getName() + ".proxied.output.format";

Configuration conf;

OutputFormat outputFormat;
protected Configuration conf;
protected OutputFormat outputFormat;

// The original mapred.output.dir
String originalDir = null;
protected String originalDir = null;
// The _temporary folder over the mapred.output.dir that will be seen by the proxied output format as the original
String baseDir = null;
protected String baseDir = null;

@Override
public void setConf(Configuration conf) {
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Expand Up @@ -80,7 +80,7 @@
<id>checkstyle-check</id>
<phase>test</phase>
<goals>
<goal>check</goal>
<goal>checkstyle</goal>
</goals>
</execution>
</executions>
Expand Down

0 comments on commit 682de05

Please sign in to comment.