Skip to content
This repository has been archived by the owner on Mar 1, 2018. It is now read-only.

Mocks for Adapter class #39

Merged

Conversation

cuducos
Copy link
Collaborator

@cuducos cuducos commented Apr 19, 2017

This PR fixes some broken tests by mocking the method from rosie.chamber_of_deputies.adapter.Adapter that downloads stuff from the original source.

For those who are new to unittest.mock:

@coveralls
Copy link

Coverage Status

Coverage increased (+8.3%) to 96.381% when pulling e3ae701 on cuducos-creating-core-module into 5ca30d9 on anaschwendler-creating-core-module.

@anaschwendler
Copy link
Collaborator

Checked @cuducos changes to my pull request and aimed to understand what he did.
Seems fine, looks good, I can work with that.

Thanks a lot @cuducos and @jtemporal ! <3

@cuducos
Copy link
Collaborator Author

cuducos commented Apr 20, 2017

Checked @cuducos changes to my pull request and aimed to understand what he did.

If you need help drop a line and I can do a walkthrough ; )

@anaschwendler anaschwendler requested a review from Irio April 20, 2017 14:09
@coveralls
Copy link

Coverage Status

Coverage increased (+8.3%) to 96.381% when pulling 4fd28b3 on cuducos-creating-core-module into 5ca30d9 on anaschwendler-creating-core-module.

@anaschwendler
Copy link
Collaborator

anaschwendler commented Apr 21, 2017

Following this code, it may be necessary to delete temporary classifiers that might be running in your enviroment.
If you used to run rosie before that, by now you need to delete all .pklfiles in /tmp/serenata-dataand run again.
If you don't do that, the error that it introduce is:
image

Thanks @jtemporal for helping me finding this.

@anaschwendler anaschwendler merged commit 4fd28b3 into anaschwendler-creating-core-module Apr 21, 2017
@anaschwendler anaschwendler deleted the cuducos-creating-core-module branch April 21, 2017 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants