Test Federal Senate integration in CI #59
Conversation
This reverts commit 218c68c.
| - coverage run rosie.py test | ||
|
|
||
| - python rosie.py run federal_senate |
There was a problem hiding this comment.
Are we actually using run not test for… testing?
There was a problem hiding this comment.
Yes, that's the idea. In the line above we run all the written tests. Here, we run federal_senate. If doesn't work for any reason, will return a non-zero exit code and make the suite fail on CI.
There was a problem hiding this comment.
Why? Because we don't have integrated tests (a journey) for the Senate app?
There was a problem hiding this comment.
so this is basically a workaround to not having journey tests? and if so wouldn't it be wiser to not do this and open up an issue "Create journey tests for federal senate"?
There was a problem hiding this comment.
I do agree, @jtemporal — but I also see the point: better to run and make sure it doesn't crash than have nothing in the CI at all. Maybe both?
There was a problem hiding this comment.
both sounds good! @cuducos
|
So I'm merging this and opening an issue based on this comment by @cuducos on having journey tests |
Chamber of Deputies still doesn't work (given its higher memory usage), but will do after some effort.