Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in SSM with Windows OS #364

Closed
IanGrimstead opened this issue Mar 17, 2020 · 1 comment
Closed

Bug in SSM with Windows OS #364

IanGrimstead opened this issue Mar 17, 2020 · 1 comment
Labels
bug Something isn't working
Projects

Comments

@IanGrimstead
Copy link
Contributor

pygrams.py crashed out when StateSpaceModel internally generates NaN.

ssm.py: dfk_llm_vard func eventually gets inf in matrix P, which produces NaN in D and then Dinv. So from then on NaN spreads across the maths...

@IanGrimstead IanGrimstead created this issue from a note in pyGrams (To do) Mar 17, 2020
@IanGrimstead IanGrimstead added the bug Something isn't working label Mar 17, 2020
@IanGrimstead
Copy link
Contributor Author

This test fails under Windows:

import unittest

from scripts.algorithms.ssm import StateSpaceModel




class SSMTests(unittest.TestCase):


    def test_StateSpaceModel_(self):

        quarterly_values = [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0,
             0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
             4, 3]

        _, _1, smooth_series_s, _intercept = StateSpaceModel(quarterly_values).run_smoothing()


IanGrimstead pushed a commit that referenced this issue Mar 17, 2020
IanGrimstead pushed a commit that referenced this issue Mar 17, 2020
@IanGrimstead IanGrimstead moved this from To do to In progress in pyGrams Mar 17, 2020
IanGrimstead pushed a commit that referenced this issue Mar 17, 2020
IanGrimstead pushed a commit that referenced this issue Mar 17, 2020
IanGrimstead added a commit that referenced this issue Mar 17, 2020
* #364 added workaround and test that proves error is caught for windows OS
@IanGrimstead IanGrimstead moved this from In progress to Reviewer approved in pyGrams Mar 17, 2020
@IanGrimstead IanGrimstead moved this from Reviewer approved to Done in pyGrams Mar 17, 2020
@mshodge mshodge closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
pyGrams
  
Done
Development

No branches or pull requests

2 participants