93 streamline ui #181
Closed
93 streamline ui #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line-UI # Conflicts: # pygrams.py
Codecov Report
@@ Coverage Diff @@
## develop #181 +/- ##
===========================================
+ Coverage 64.93% 65.02% +0.08%
===========================================
Files 23 23
Lines 1158 1135 -23
===========================================
- Hits 752 738 -14
+ Misses 406 397 -9 |
IanGrimstead
suggested changes
Mar 15, 2019
tests/test_pygrams.py
Outdated
| def test_args_json_not_requested(self): | ||
| args = pygrams.get_args([]) | ||
| self.assertFalse(args.json) | ||
| # not sure of the purpose of this! |
There was a problem hiding this comment.
This test allegedly was to test that if json was not requested, args.json should be false...
There was a problem hiding this comment.
we said that it is going to be core output now, so shall we get rid of?
There was a problem hiding this comment.
It tests if the arg parser handles json
Co-Authored-By: thanasions <33151187+thanasions@users.noreply.github.com>
Co-Authored-By: thanasions <33151187+thanasions@users.noreply.github.com>
Co-Authored-By: thanasions <33151187+thanasions@users.noreply.github.com>
Co-Authored-By: thanasions <33151187+thanasions@users.noreply.github.com>
Co-Authored-By: thanasions <33151187+thanasions@users.noreply.github.com>
Co-Authored-By: thanasions <33151187+thanasions@users.noreply.github.com>
IanGrimstead
approved these changes
Mar 15, 2019
|
resolves #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.