Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency Codes #16

Closed
KitWallace opened this issue Apr 24, 2013 · 3 comments
Closed

Currency Codes #16

KitWallace opened this issue Apr 24, 2013 · 3 comments

Comments

@KitWallace
Copy link

The links need to be updated - (coincidentally I commented on this in the datahub http://datahub.io/dataset/iso-4217-currency-codes a couple of hours ago)

This table is not really currency codes, its country/currency codes so is denormalized so USD appears in several places as a result. The table is misnamed and less useful as a result.

Oddly too, the reference to a country is by name not by ISO 3166 code. Do you have a policy around linking/foreign keys?

Of course, some folk would use the XML 'package' directly http://www.currency-iso.org/dam/downloads/dl_iso_table_a1.xml :)

@rufuspollock
Copy link
Member

@KitWallace can you do a pull request? iso 3166 codes would be best.

@KitWallace
Copy link
Author

But should country be there at all? Maybe both the country/currency table and a factored currency table would be better? Looking more closely at the data, I see that an additional country code would be needed because entity is not always a country.

@rufuspollock
Copy link
Member

Moving to datasets/currency-codes#1 where it should be (registry is just for new datasets)

rufuspollock pushed a commit that referenced this issue Dec 15, 2019
#16)

* [home-page][s]: added more sections and descriptions about world bank open datasets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants