Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial plugin design #1

Closed
simonw opened this issue Feb 9, 2024 · 4 comments
Closed

Initial plugin design #1

simonw opened this issue Feb 9, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Contributor

simonw commented Feb 9, 2024

It's going to use https://pypi.org/project/quickjs/ to evaluate JavaScript, with a time limit.

@simonw simonw added the enhancement New feature or request label Feb 9, 2024
@simonw
Copy link
Contributor Author

simonw commented Feb 9, 2024

I got a prototype working! UI looks like this:

CleanShot 2024-02-09 at 09 20 03@2x

So it detects invalid JavaScript. If the function IS valid it runs and works.

@simonw
Copy link
Contributor Author

simonw commented Feb 9, 2024

Currently running this in the main thread with a time limit. Would be good to have this run in a thread instead.

simonw added a commit that referenced this issue Feb 9, 2024
@simonw
Copy link
Contributor Author

simonw commented Feb 9, 2024

I can ship an alpha of this if I write some documentation and tests.

simonw added a commit that referenced this issue Feb 9, 2024
simonw added a commit that referenced this issue Feb 9, 2024
@simonw
Copy link
Contributor Author

simonw commented Feb 9, 2024

@simonw simonw closed this as completed Feb 9, 2024
simonw added a commit that referenced this issue Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant