Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_config_form() should take datasette as first argument #22

Closed
simonw opened this issue Nov 25, 2023 · 1 comment
Closed

get_config_form() should take datasette as first argument #22

simonw opened this issue Nov 25, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@simonw
Copy link
Collaborator

simonw commented Nov 25, 2023

Don't forget to update documentation as well.

async def get_config_form(self, db, table):

@simonw simonw added the enhancement New feature or request label Nov 25, 2023
@simonw
Copy link
Collaborator Author

simonw commented Nov 25, 2023

Documentation to update:

# ...
async def get_config_form(self, db, table):
class ConfigForm(Form):

That documentation also needs to list all of the arguments, like it does for the other methods.

@simonw simonw added this to the First alpha milestone Nov 25, 2023
simonw added a commit that referenced this issue Nov 28, 2023
@simonw simonw closed this as completed in 00a4bad Nov 28, 2023
simonw added a commit that referenced this issue Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant