generated from simonw/datasette-plugin-template-repository
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch description_html
to description
and obtain_url
and obtain_label
#12
Labels
enhancement
New feature or request
Comments
I'm going to make it an optional thing called |
... no I'm going to have a field for the label and a field for the URL. I don't like the accessibility implications of having a lot of URLs with the same label. |
Updated the demo plugin: https://gist.github.com/simonw/d6c3500ea0c77499034df6b4e409e3e3 from datasette_secrets import Secret
from datasette import hookimpl
@hookimpl
def register_secrets():
return [
Secret(
name="DEMO_SECRET_ONE",
description="First demo secret",
),
Secret(
name="DEMO_SECRET_TWO",
description="Second demo secret",
obtain_url="https://www.example.com/",
obtain_label="Example",
),
Secret(
name="DEMO_SECRET_THREE",
obtain_url="https://three.example.com/",
obtain_label="Example 3",
),
] datasette install https://gist.github.com/simonw/d6c3500ea0c77499034df6b4e409e3e3/archive/0042a7ffd7bcf35a42d00874171a57159c69458a.zip |
simonw
changed the title
I don't like
I don't like Apr 24, 2024
description_html
- switch to description
and url
description_html
- switch to description
and obtain_url
and obtain_label
simonw
changed the title
I don't like
Switch Apr 24, 2024
description_html
- switch to description
and obtain_url
and obtain_label
description_html
to description
and obtain_url
and obtain_label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don't like having HTML in the system like this. Instead I'll field the URL you can obtain a secret from separately.
datasette-secrets/datasette_secrets/__init__.py
Lines 129 to 132 in 42d4980
datasette-secrets/datasette_secrets/__init__.py
Lines 55 to 58 in 42d4980
The text was updated successfully, but these errors were encountered: