Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent HTTP 500 Statuscode on non existent history element #132

Closed
schwzr opened this issue Nov 12, 2023 · 0 comments · Fixed by #149 or #157
Closed

Prevent HTTP 500 Statuscode on non existent history element #132

schwzr opened this issue Nov 12, 2023 · 0 comments · Fixed by #149 or #157
Assignees
@hhund
Labels
bug Something isn't working ready for release Issue is fixed and merged into develop, ready for next release
Milestone
1.4.0

Comments

@schwzr
Copy link
Member

schwzr commented Nov 12, 2023

When you try to access the version after the current version (e.g. the current version is 6 and you try to access version 7) you will receive a HTTP status code 500.

The exception thrown is

jakarta.servlet.ServletException: java.lang.NullPointerException: Cannot invoke "java.time.LocalDateTime.atZone(java.time.ZoneId)" because the return value of "dev.dsf.fhir.dao.exception.ResourceDeletedException.getDeleted()" is null

Every other version is working correctly (existing version numbers and e.g. 999).
@wetret wetret added the bug Something isn't working label Nov 14, 2023
@hhund hhund self-assigned this Dec 9, 2023
@hhund hhund added this to the 1.4.0 milestone Dec 9, 2023
hhund added a commit that referenced this issue Dec 9, 2023
@hhund
tests to reproduce issue #132
cc2ec88
@hhund hhund mentioned this issue Dec 9, 2023
Merged
@hhund hhund linked a pull request Dec 9, 2023 that will close this issue
Issues/132 non existent history element 500 #149
Merged
hhund added a commit that referenced this issue Dec 9, 2023
@hhund
fix for issue #132
c64478d
@hhund hhund added the ready for release Issue is fixed and merged into develop, ready for next release label Dec 11, 2023
@hhund hhund mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hhund hhund

Labels
bug Something isn't working ready for release Issue is fixed and merged into develop, ready for next release
Projects
None yet
Milestone
1.4.0
3 participants
@schwzr @wetret @hhund