Fixed test corresponding with change to account.usage method

MeltwaterArchive · Jan 16, 2018 · 9c5ceb3 · 9c5ceb3
1 parent e55fc56
commit 9c5ceb3
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 7 deletions.
diff --git a/test/datasift/account/account_api_test.rb b/test/datasift/account/account_api_test.rb
@@ -12,18 +12,30 @@
     it 'can get account usage using valid params' do
       VCR.use_cassette("#{@datasift.config[:api_version]}" + '/account/usage/valid_params') do
         response = @datasift.account.usage(
-          'daily',
           1490054400,
-          1490572800
+          1490572800,
+          'daily'
         )
         assert_equal STATUS.valid, response[:http][:status]
       end
     end
 
+    it 'raises argument error when using invalid params' do
+      VCR.use_cassette("#{@datasift.config[:api_version]}" + '/account/usage/invalid') do
+        assert_raises ArgumentError do
+          @datasift.account.usage()
+        end
+      end
+    end
+
     it 'handles 400 when using invalid params' do
       VCR.use_cassette("#{@datasift.config[:api_version]}" + '/account/usage/invalid') do
         assert_raises BadRequestError do
-          @datasift.account.usage('invalid_period')
+          @datasift.account.usage(
+          1490054400,
+          1490572800,
+          'invalid_period'
+        )
         end
       end
     end

diff --git a/test/fixtures/cassettes/v1_4/account/usage/invalid.json b/test/fixtures/cassettes/v1_4/account/usage/invalid.json
@@ -1 +1 @@
-{"http_interactions":[{"request":{"method":"get","uri":"https://api.datasift.com/v1.4/account/usage?period=invalid_period","body":{"encoding":"US-ASCII","base64_string":""},"headers":{"Accept":["*/*"],"Accept-Encoding":["gzip, deflate"],"User-Agent":["DataSift/v1.4 Ruby/v3.8.0"],"Authorization":["<USERNAME:API_KEY>"],"Host":["api.datasift.com"]}},"response":{"status":{"code":400,"message":"Bad Request"},"headers":{"Server":["nginx"],"Date":["Fri, 19 May 2017 13:16:17 GMT"],"Content-Type":["application/json"],"Transfer-Encoding":["chunked"],"X-Api-Version":["1.4"],"X-Xss-Protection":["1; mode=block"],"X-Content-Type-Options":["nosniff"],"X-Datasift-Request-Id":["7afd4dc88b900f243fe9855fe5fe0848"],"P3p":["CP=\"CAO PSA\""],"X-Ratelimit-Limit":["100000"],"X-Ratelimit-Remaining":["99925"],"X-Ratelimit-Cost":["25"],"X-Ratelimit-Reset":["1495203362"],"X-Ratelimit-Reset-Ttl":["3585"],"Access-Control-Allow-Origin":["*"],"Access-Control-Allow-Headers":["Authorization,Content-Type"],"Access-Control-Allow-Methods":["GET,POST,PUT,DELETE"],"X-Balanced-By":["sft222"]},"body":{"encoding":"UTF-8","base64_string":"eyJlcnJvciI6InBlcmlvZCBpcyBpbnZhbGlkOyB2YWxpZCB2YWx1ZXMgYXJl\nOiBob3VybHksZGFpbHksbW9udGhseSJ9\n"},"http_version":null},"recorded_at":"Fri, 19 May 2017 13:16:17 GMT"}],"recorded_with":"VCR 3.0.3"}
+{"http_interactions":[{"request":{"method":"get","uri":"https://api.datasift.com/v1.4/account/usage?end=1490572800&period=invalid_period&start=1490054400","body":{"encoding":"US-ASCII","base64_string":""},"headers":{"Accept":["*/*"],"Accept-Encoding":["gzip, deflate"],"User-Agent":["DataSift/v1.4 Ruby/v3.10.0"],"Authorization":["<USERNAME:API_KEY>"],"Host":["api.datasift.com"]}},"response":{"status":{"code":400,"message":"Bad Request"},"headers":{"Server":["nginx"],"Date":["Tue, 16 Jan 2018 21:27:46 GMT"],"Content-Type":["application/json"],"Transfer-Encoding":["chunked"],"X-Api-Version":["1.4"],"X-Xss-Protection":["1; mode=block"],"X-Content-Type-Options":["nosniff"],"X-Datasift-Request-Id":["c53bd378c9f8b96c64b89e6b2321aa55"],"P3p":["CP=\"CAO PSA\""],"X-Ratelimit-Limit":["100000"],"X-Ratelimit-Remaining":["98660"],"X-Ratelimit-Cost":["25"],"X-Ratelimit-Reset":["1516141283"],"X-Ratelimit-Reset-Ttl":["3217"],"Access-Control-Allow-Origin":["*"],"Access-Control-Allow-Headers":["Authorization,Content-Type"],"Access-Control-Allow-Methods":["GET,POST,PUT,DELETE"],"X-Balanced-By":["sft252"]},"body":{"encoding":"UTF-8","base64_string":"eyJlcnJvciI6InBlcmlvZCBpcyBpbnZhbGlkOyB2YWxpZCB2YWx1ZXMgYXJl\nOiBob3VybHksZGFpbHksbW9udGhseSJ9\n"},"http_version":null},"recorded_at":"Tue, 16 Jan 2018 21:27:46 GMT"}],"recorded_with":"VCR 3.0.3"}