This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Fix two name clashes with Windows includes #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ERROR is a macro in wingdi.h. It can be avoided by defining NOGDI - DELETE is a macro in winnt.h. It has to be undefined
plule-ansys
changed the title
|
Looks good, thanks @plule-ansys! |
|
I've tried the current master version on Windows under Mingw64, but get many of these ERROR and DELETE conflicts. |
|
@jputcu Hello, using bazel the build seems to be still OK on Windows. If you are using CMake, I think you have to manually define NOGDI and possibly _MSC_VER in the CMakeList.txt. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERROR is a macro in wingdi.h. It can be avoided by defining NOGDI at build level.
DELETE is a macro in winnt.h. It has to be undefined.
Unfortunately I don't see a better fix except renaming the enum members.