Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the devops DEFAULT_DEV_OPS_URL to include the protocol #197

Closed
hemidactylus opened this issue Feb 7, 2024 · 0 comments · Fixed by #199
Closed

Extend the devops DEFAULT_DEV_OPS_URL to include the protocol #197

hemidactylus opened this issue Feb 7, 2024 · 0 comments · Fixed by #199
Assignees
Labels
enhancement New feature or request

Comments

@hemidactylus
Copy link
Collaborator

In the AstraDBOps, the current definition of

DEFAULT_DEV_OPS_URL = "api.astra.datastax.com"

makes it impossible to test against e.g. a local (http, not https) endpoint unless one tweaks the class internals.

Suggestion: refactor the default and the behaviour in the constructor to allow specifying any arbitrary URI. This would touch the above as well as the line in the constructor currently like this:

self.base_url = f"https://{dev_ops_url}/{dev_ops_api_version}"
@hemidactylus hemidactylus added the enhancement New feature or request label Feb 7, 2024
erichare added a commit that referenced this issue Feb 7, 2024
@erichare erichare self-assigned this Feb 7, 2024
@erichare erichare linked a pull request Feb 7, 2024 that will close this issue
hemidactylus added a commit that referenced this issue Feb 8, 2024
Co-authored-by: Stefano Lottini <stefano.lottini@datastax.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants