Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Most JSON-y parameters have "null-like" defaults despite no API support #80

Closed
erichare opened this issue Nov 7, 2023 · 3 comments
Labels
bug Something isn't working core "core" astrapy is not meant for external use anymore documentation Improvements or additions to documentation

Comments

@erichare
Copy link
Collaborator

erichare commented Nov 7, 2023

Remove defaults, require the params be passed if required by API

@erichare erichare self-assigned this Nov 7, 2023
@erichare erichare removed their assignment Nov 20, 2023
@hemidactylus
Copy link
Collaborator

This is especially evident in ops.py which would need some love (and ample work in digging through the docs + challenging stuff for better testing)

@erichare erichare added bug Something isn't working documentation Improvements or additions to documentation labels Jan 2, 2024
@erichare
Copy link
Collaborator Author

erichare commented Feb 8, 2024

@hemidactylus do you think this can now be closed in favor of the love to ops task, which of course requires a ton of work.... but with the db.py functions it seems we're in a much better spot than we were, and can maybe handle on a case by case basis?

@hemidactylus hemidactylus changed the title Most JSON-y parameters have "null-like" defaults despite no API support [core] Most JSON-y parameters have "null-like" defaults despite no API support Apr 11, 2024
@hemidactylus hemidactylus added the core "core" astrapy is not meant for external use anymore label Apr 11, 2024
@hemidactylus
Copy link
Collaborator

closing as core is being (slowly) abandoned in favour of "pure idiomatic"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core "core" astrapy is not meant for external use anymore documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants