Add tests for collection "indexing" settings #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: 1.0.0-RC3 is in prod now, which has full support for indexing. Tests indeed all pass. |
|
Still having local test issues, out of caution I'll come back to this before merging, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two test on two new collections created with different non-default indexing settings: one is allow-list based, the other is deny-list based. Various filters are tested and it is verified they work (or don't) as expected.
I did not deem it necessary to double these tests in the async half of tests.
Tested in dev, 100% pass.
Do not merge yet, until the indexing makes it to prod.
Note: with these, the collections used in the test are now five. To avoid the "too many collections" error breaking the create-and-then-destroy-collection tests, these two are scoped to function (there are only 1 function using each of the two, anyway). In case deletions are suspended, no problem again since the tests at risk would be skipped.