Upgrade pulsar client to 3.0.0 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
It's fine to upgrade to 2.10.4.
However, you can upgrade up to 3.0 as the Pulsar client and Pulsar Admin libraries work on jdk8 and also the Pulsar Functions APIs work on jdk11 (and you don't bundle them in the nar, even if they are compiled for jdk17).
The fact is that you will need to use jdk17 to compile the project (and also ensure that the release parameter is passed to javac and set to 11).
If we run the Pulsar server components I'm the tests then we must use jdk17 to run the tests.
In Pulsar JMS we have also server side components (the filters) that use apis compiled for jdk17 but that are not bundled into the .nar, and everything still works well on jdk11
aymkhalil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time #144 was implemented, pulsar client 2.10.4 was not released. This patch is a follow up to use the recommended version. Please note that 2.11 is not possible to use atm because it required java 17 CDC need to compile with java 11,