New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit reference to System.Net.Http #531
Conversation
The assembly is only used in CloudMetadataService for .NET Standard builds but System.Net.Http is built-in in .NET Standard and doesn't need an explicit reference. Solution mixing nuget and built-in references to System.Net.Http leads to runtime issues that we are trying to solve by removing the nuget references. dotnet/runtime#26131 (comment) > In most cases, we don't advise people use the separate System.Net.Http > NuGet package anymore
Hmm I think that we were required to add it for I want to run some more tests to make sure nothing breaks and I'll try to write an implementation of I should have an update about this soon. Is this urgent or can you wait for the next release? (The next release should be out around end of August / early September). |
Thanks for the quick response. We will be using my fork until the next release as this issue is in our critical path. The jenkins pipeline was not successful. Is it something I should worry about? |
No, the first run was green but this one ran the nightly suite and it had a couple of test failures which I will investigate later, they are not related to this change. We can get out a patch release with just this change if this is blocking you, I'll run the tests that I need to run after the weekend and after that I will merge this PR and push a new patch release. |
I would be, indeed, very interested in a quick release with this change, thanks :) |
Just fyi 3.15.1 has been published to nuget.org: https://www.nuget.org/packages/CassandraCSharpDriver/3.15.1 Mailing list thread: https://groups.google.com/a/lists.datastax.com/d/msg/csharp-driver-user/jUbrVTAKqQA/-rqofs1iCAAJ |
Thank you :) |
The assembly is only used in CloudMetadataService for .NET Standard
builds but System.Net.Http is built-in in .NET Standard and doesn't
need an explicit reference.
Solution mixing nuget and built-in references to System.Net.Http leads
to runtime issues that we are trying to solve by removing the nuget
references.
dotnet/runtime#26131 (comment)