Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAVA-2563 and JAVA-2564 #20
JAVA-2563 and JAVA-2564 #20
Changes from 54 commits
d746998
c1279ec
a83b146
3fa0fd4
ecd60a7
ce3225b
f365d98
192d7bf
1915246
da75ad1
cff2478
01b87b4
7521b1e
bf85985
c488c5a
632eea8
b55391f
b45d2de
0a9d372
ef25ca6
06aab95
b56f341
fca261f
62d8326
3183a44
1c06158
88089e3
6919b02
272548b
7ed38d5
b8ff9ea
1fb447b
02fe912
bfcb171
2f5c474
9da8cca
17117d1
e00ad38
64f9bb4
1bffa1a
29e69f3
2f48dc2
637cd78
d1be0a6
3432a92
539edf9
a70f4af
545df55
993aaa4
c6962bb
74b668c
1658c56
bf767a9
41dcc4b
7754017
803c2c7
568c3a3
2991fdd
5929a6d
0b5172e
3adbda5
cca2ef9
1c69582
228a4e8
7d9396a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of the checks above reflects an API change. Going forward the intent is to access the underlying ResultSet impl directly (via the appropriate "resultSet" check) and then extract the desired information via .transform() + fns defined somewhere in the code. Users can define these transform fns in their own simulations, in library code, etc. This has the effect of making the check API simpler and more streamlined while allowing users to extend it in a natural way by defining their own fns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the simplification goal. And it is a good time to do this, given that all user simulations will break anyway, because of the DseCluster/DseSession class change in the 4.x branch. May I ask for a small documentation where this decision is explained and the replacement code is provided for deleted checks, to make things easier for users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extensive scaladoc has been added on this point in DseCheckSupport. @pingtimeout would you mind taking a look and confirming that this addresses the points you wanted to see covered?
This file was deleted.