-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAVA-1287: Add CDC to TableOptionsMetadata and Schema Builder #745
Conversation
@@ -358,6 +360,19 @@ public T speculativeRetry(SpeculativeRetryValue speculativeRetry) { | |||
} | |||
|
|||
/** | |||
* Define whether or not change data capture is enabled on this table. | |||
* <p/> | |||
* If no call is made to this method, the default value set by Cassandra is {@code false}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we warn users that if they call this method and later on execute this statement against C* < 3.8 they will get an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, we definitely should, will push update.
👍 CREATE KEYSPACE ks WITH replication... AND cdc_datacenters= {'dc1','dc2'...};
ALTER KEYSPACE ks DROP CDCLOG; But I couldn't find any reference to these changes in the current C* trunk, so I guess it's been abandoned. |
I'll look into that, I would think there should still be a way to drop the existing logs, maybe it's not done through CQL now. |
Didn't find anything in the C* commit other than the |
Changed base to 3.x, make sure you use that branch for future rebases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on 3.x and fixed the changelog.
This looks good to me 👍
In support of CASSANDRA-12041, add support for parsing cdc from table options and add support for specification using schema builder.
In support of CASSANDRA-12041, add support for parsing cdc from table
options and add support for specification using schema builder.
For JAVA-1287.