Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAVA-1287: Add CDC to TableOptionsMetadata and Schema Builder #745

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Conversation

tolbertam
Copy link
Contributor

In support of CASSANDRA-12041, add support for parsing cdc from table
options and add support for specification using schema builder.

For JAVA-1287.

@@ -358,6 +360,19 @@ public T speculativeRetry(SpeculativeRetryValue speculativeRetry) {
}

/**
* Define whether or not change data capture is enabled on this table.
* <p/>
* If no call is made to this method, the default value set by Cassandra is {@code false}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we warn users that if they call this method and later on execute this statement against C* < 3.8 they will get an error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, we definitely should, will push update.

@adutra
Copy link
Contributor

adutra commented Sep 12, 2016

👍
It's odd because the C* ticket also mentions a syntax change for keyspaces, e.g.:

CREATE KEYSPACE ks WITH replication... AND cdc_datacenters= {'dc1','dc2'...};
ALTER KEYSPACE ks DROP CDCLOG;

But I couldn't find any reference to these changes in the current C* trunk, so I guess it's been abandoned.

@tolbertam
Copy link
Contributor Author

But I couldn't find any reference to these changes in the current C* trunk, so I guess it's been abandoned.

I'll look into that, I would think there should still be a way to drop the existing logs, maybe it's not done through CQL now.

@tolbertam
Copy link
Contributor Author

I'll look into that, I would think there should still be a way to drop the existing logs, maybe it's not done through CQL now.

Didn't find anything in the C* commit other than the with CDC option for CQL, also didn't see any other way to drop the cdclogs from what I can tell.

@olim7t olim7t changed the base branch from 3.0 to 3.x September 14, 2016 22:24
@olim7t
Copy link
Contributor

olim7t commented Sep 14, 2016

Changed base to 3.x, make sure you use that branch for future rebases.

@adutra adutra added this to the 3.2.0 milestone Dec 22, 2016
@adutra adutra removed the reviewed_AD label Jan 4, 2017
Copy link
Contributor

@olim7t olim7t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on 3.x and fixed the changelog.
This looks good to me 👍

In support of CASSANDRA-12041, add support for parsing cdc from table
options and add support for specification using schema builder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants