Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable annotations on services #131

Closed
robparrott opened this issue Jan 25, 2022 · 1 comment · Fixed by #142
Closed

Enable annotations on services #131

robparrott opened this issue Jan 25, 2022 · 1 comment · Fixed by #142

Comments

@robparrott
Copy link

The following services do not support annotations, which mean that on AWS you cannot control the load balancer type used:

  • broker
  • pulsarSql
@michaeljmarshall michaeljmarshall mentioned this issue Jan 29, 2022
Merged
@michaeljmarshall
Copy link
Member

@robparrott - thanks for identifying this feature gap! I am about to merge a PR with the fix. Please let me know if you see any issues.

pgier pushed a commit to pgier/datastax-pulsar-helm-chart that referenced this issue Jul 13, 2022
@volgorean
Updates internal issuer cert to include duration and renew configs (d…
d6d240a 
…atastax#131)

### Motivation
* While component certs can be configured with a custom duration the CA cert for self-signed configuration uses default values. It can be convenient to have this certificate expire more than a month out.

### Modifications
* Updates the internal issuer `{{ .Release.Name }}-ca-tls` certificate to make `duration` and `renewBefore` configurable. Does not use `common` so that the CA can be configured to last much longer than individual components certs if desired.

### Verifying this change
- [x] Make sure that the change passes the CI checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable annotation configuration for broker and pulsar sql services datastax/pulsar-helm-chart
2 participants
@robparrott @michaeljmarshall