-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HostFilterPolicyInitTest fix for Python 3.11 #1131
Conversation
The AttributeError message for a missing property setter changed in bpo-46730.
Thanks for the pull request @stefanor! Have you signed the Contributor License Agreement for contributions to DataStax open source projects? If not you can find it at https://cla.datastax.com/. Thanks! |
I have now signed it. |
Without knowing much you probably have to change the build configuration adding |
also |
That's great news @stefanor! This PR looks pretty good to me so I think we're okay to merge as it stands. We will add Python 3.11 support for tests at some point in the future but it should be noted that the Python driver does not currently support anything beyond Python 3.8. We have plans to make this better in the future but for now my chief concern is making sure that we don't break functionality in any < 3.11 releases. @stefanor's PR is structured to prevent any such failures and indeed the green Travis CI run persuades me that we are in fact fine for those versions. Given all of that I'm fine merging this guy as-is. Thanks again @stefanor! |
Thank you kindly for the prompt response |
version 3.26.0 * tag '3.26.0' of https://github.com/datastax/python-driver: (22 commits) Release 3.26: changelog & version Going back to known good non-2.7 PyPy target. PYTHON-1333 has more detail. Forgot to add complete extension Trying to get to a maximal working Pypy version. Have to go back to 3.6 which isn't ideal... Update Travis config to only run versions that will be supported going forward Minor refactor of prior commit: now that we're dropping 2.7.x support we don't really need to leverage six for unit test functions. Remove references to unsupported Python versions from setup.py Refactor deprecated unittest aliases for Python 3.11 compatibility. (datastax#1112) Merge pull request datastax#1140 from python-driver/python-1327 Merge pull request datastax#1139 from python-driver/python-1328 Merge pull request datastax#1137 from python-driver/python-1329 Merge pull request datastax#1128 from python-driver/python-1304 Fix jenkins builds (datastax#1134) Minor refactor of prior commit Handle "log gone" case in the end of _run_loop (datastax#1133) HostFilterPolicyInitTest fix for Python 3.11 (datastax#1131) Groovy fixes Hey, let's actually update the right things, shall we? Smaller smoke test configuration to avoid explosion of test builds in AWS Fix to prior fix ...
version 3.26.0 * tag '3.26.0' of https://github.com/datastax/python-driver: (22 commits) Release 3.26: changelog & version Going back to known good non-2.7 PyPy target. PYTHON-1333 has more detail. Forgot to add complete extension Trying to get to a maximal working Pypy version. Have to go back to 3.6 which isn't ideal... Update Travis config to only run versions that will be supported going forward Minor refactor of prior commit: now that we're dropping 2.7.x support we don't really need to leverage six for unit test functions. Remove references to unsupported Python versions from setup.py Refactor deprecated unittest aliases for Python 3.11 compatibility. (datastax#1112) Merge pull request datastax#1140 from python-driver/python-1327 Merge pull request datastax#1139 from python-driver/python-1328 Merge pull request datastax#1137 from python-driver/python-1329 Merge pull request datastax#1128 from python-driver/python-1304 Fix jenkins builds (datastax#1134) Minor refactor of prior commit Handle "log gone" case in the end of _run_loop (datastax#1133) HostFilterPolicyInitTest fix for Python 3.11 (datastax#1131) Groovy fixes Hey, let's actually update the right things, shall we? Smaller smoke test configuration to avoid explosion of test builds in AWS Fix to prior fix ...
The AttributeError message for a missing property setter changed in bpo-46730.