Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HostFilterPolicyInitTest fix for Python 3.11 #1131

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

stefanor
Copy link
Contributor

The AttributeError message for a missing property setter changed in bpo-46730.

The AttributeError message for a missing property setter changed in
bpo-46730.
@absurdfarce
Copy link
Collaborator

Thanks for the pull request @stefanor!

Have you signed the Contributor License Agreement for contributions to DataStax open source projects? If not you can find it at https://cla.datastax.com/. Thanks!

@stefanor
Copy link
Contributor Author

stefanor commented Jan 3, 2023

I have now signed it.

@pepgid
Copy link

pepgid commented Jan 4, 2023

Without knowing much you probably have to change the build configuration
"python": [
"2.7",
"3.5",
"3.6",
"3.7",
"3.8",
"pypy2.7-6.0",
"pypy3.5"
],

adding
"python": [
"2.7",
"3.5",
"3.6",
"3.7",
"3.8",
"3.11",
"pypy2.7-6.0",
"pypy3.5"
],

@pepgid
Copy link

pepgid commented Jan 4, 2023

also
Environment: PYTHON=C:\Python35-x64, cassandra_version=3.11.2, ci_type=standard
should be
Environment: PYTHON=C:\Python3.11-x64, cassandra_version=3.11.2, ci_type=standard

@absurdfarce
Copy link
Collaborator

absurdfarce commented Jan 5, 2023

That's great news @stefanor! This PR looks pretty good to me so I think we're okay to merge as it stands.

We will add Python 3.11 support for tests at some point in the future but it should be noted that the Python driver does not currently support anything beyond Python 3.8. We have plans to make this better in the future but for now my chief concern is making sure that we don't break functionality in any < 3.11 releases. @stefanor's PR is structured to prevent any such failures and indeed the green Travis CI run persuades me that we are in fact fine for those versions.

Given all of that I'm fine merging this guy as-is.

Thanks again @stefanor!

@absurdfarce absurdfarce merged commit dee9595 into datastax:master Jan 5, 2023
@absurdfarce absurdfarce changed the title Python 3.11 support [bpo-46730] HostFilterPolicyInitTest fix for Python 3.11 Jan 5, 2023
@pepgid
Copy link

pepgid commented Jan 5, 2023

Thank you kindly for the prompt response

Lorak-mmk added a commit to Lorak-mmk/python-driver that referenced this pull request Mar 31, 2023
version 3.26.0

* tag '3.26.0' of https://github.com/datastax/python-driver: (22 commits)
  Release 3.26: changelog & version
  Going back to known good non-2.7 PyPy target.  PYTHON-1333 has more detail.
  Forgot to add complete extension
  Trying to get to a maximal working Pypy version.  Have to go back to 3.6 which isn't ideal...
  Update Travis config to only run versions that will be supported going forward
  Minor refactor of prior commit: now that we're dropping 2.7.x support we don't really need to leverage six for unit test functions.
  Remove references to unsupported Python versions from setup.py
  Refactor deprecated unittest aliases for Python 3.11 compatibility. (datastax#1112)
  Merge pull request datastax#1140 from python-driver/python-1327
  Merge pull request datastax#1139 from python-driver/python-1328
  Merge pull request datastax#1137 from python-driver/python-1329
  Merge pull request datastax#1128 from python-driver/python-1304
  Fix jenkins builds (datastax#1134)
  Minor refactor of prior commit
  Handle "log gone" case in the end of _run_loop (datastax#1133)
  HostFilterPolicyInitTest fix for Python 3.11 (datastax#1131)
  Groovy fixes
  Hey, let's actually update the right things, shall we?
  Smaller smoke test configuration to avoid explosion of test builds in AWS
  Fix to prior fix
  ...
Lorak-mmk added a commit to Lorak-mmk/python-driver that referenced this pull request Apr 12, 2023
version 3.26.0

* tag '3.26.0' of https://github.com/datastax/python-driver: (22 commits)
  Release 3.26: changelog & version
  Going back to known good non-2.7 PyPy target.  PYTHON-1333 has more detail.
  Forgot to add complete extension
  Trying to get to a maximal working Pypy version.  Have to go back to 3.6 which isn't ideal...
  Update Travis config to only run versions that will be supported going forward
  Minor refactor of prior commit: now that we're dropping 2.7.x support we don't really need to leverage six for unit test functions.
  Remove references to unsupported Python versions from setup.py
  Refactor deprecated unittest aliases for Python 3.11 compatibility. (datastax#1112)
  Merge pull request datastax#1140 from python-driver/python-1327
  Merge pull request datastax#1139 from python-driver/python-1328
  Merge pull request datastax#1137 from python-driver/python-1329
  Merge pull request datastax#1128 from python-driver/python-1304
  Fix jenkins builds (datastax#1134)
  Minor refactor of prior commit
  Handle "log gone" case in the end of _run_loop (datastax#1133)
  HostFilterPolicyInitTest fix for Python 3.11 (datastax#1131)
  Groovy fixes
  Hey, let's actually update the right things, shall we?
  Smaller smoke test configuration to avoid explosion of test builds in AWS
  Fix to prior fix
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants