Support new 'date' and 'time' types in Cassandra #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,7 @@ def _make_packer(format_string): | |||
| unpack = lambda s: packer.unpack(s)[0] | |||
| return pack, unpack | |||
|
|
|||
| uint32_pack, uint32_unpack = _make_packer('I') | |||
There was a problem hiding this comment.
Why no explicit big-endian '>' ?
|
I put a couple of comments on the diff. @josh-mckenzie would you consider rebasing to squash out some of the 'cleanup print'-type commits? |
|
Sure thing - I'll try to get to that today and push updates. |
jmckenzie-dev
force-pushed
the
7523_squashed
branch
from
292f3df
to
8562fd0
Compare
|
Removed debug print, removed redundant uint32_pack that was missing endianness, squashed to single commit, and branch is updated. |
|
@josh-mckenzie I'd like to get an idea for where this C* issue lands in your list of priorities. Are you gunning for next 2.1.x release with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CASSANDRA-7523
PYTHON-190