Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests of Murmur hash algorithm on big endian platforms #762

Closed
wants to merge 1 commit into from

Conversation

frenzymadness
Copy link

Because Murmur algorithm is optimized for different platforms, it produces different results on little/big endian systems.
These changes only split results check for little/big endian systems.

@datastax-bot
Copy link

Hi @frenzymadness, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

Sincerely,
DataStax Bot.

@datastax-bot
Copy link

Thank you @frenzymadness for signing the Contribution License Agreement.

Cheers,
DataStax Bot.

@mambocab
Copy link
Contributor

Thanks for the PR, I appreciate it. However, I believe it's actually correct for the test, as it exists on master, to fail -- our murmur3 implementation should return results consistent with the server's implementation regardless of the platform. I'm going to close and schedule PYTHON-653 for evaluation for version 3.11, as we don't have time to schedule it in sooner.

@mambocab mambocab closed this May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants