Skip to content

Commit

Permalink
add some description
Browse files Browse the repository at this point in the history
  • Loading branch information
coolderli committed May 24, 2024
1 parent 6f1cfaa commit 75b8a16
Showing 1 changed file with 9 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ private FactoryUtils() {}

private static final Logger LOG = LoggerFactory.getLogger(FactoryUtils.class);

/** Utility for working with {@link Factory}s. */
/**
* Utility for working with {@link Factory}s. The {@link GravitinoCatalogFactoryHelper} override
* the {@link FactoryUtil.CatalogFactoryHelper#validate()} method to validate the options. For the
* unconsumed option keys, it logs a warning instead of throwing an exception.
*/
public static class GravitinoCatalogFactoryHelper extends FactoryUtil.CatalogFactoryHelper {

private GravitinoCatalogFactoryHelper(
Expand All @@ -42,7 +46,10 @@ public void validate() {
}
}

/** Validates unconsumed option keys. */
/**
* Validates unconsumed option keys. Logs a warning for each unconsumed option key instead of
* throwing an exception.
*/
private static void ignoreUnconsumedKeys(
String factoryIdentifier,
Set<String> allOptionKeys,
Expand Down

0 comments on commit 75b8a16

Please sign in to comment.