Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtask]Add KV backend storage interface for EntityStore #122

Closed
Tracked by #50
yuqi1129 opened this issue Jul 25, 2023 · 0 comments · Fixed by #123
Closed
Tracked by #50

[Subtask]Add KV backend storage interface for EntityStore #122

yuqi1129 opened this issue Jul 25, 2023 · 0 comments · Fixed by #123
Assignees

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jul 25, 2023

Describe the proposal

This issue only adds the interface for key-value storage of EntityStore, Detailed implementation will be proposed in next PR

@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Jul 25, 2023
jerryshao pushed a commit that referenced this issue Jul 26, 2023
…123)

### What changes were proposed in this pull request?
This PR only add the KV backend interface for EntityStore

### Why are the changes needed?

Currently, We only support storing entity in memory and can't keep it in
persistent storage which will be used latter

Fix: #122 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Not yet
jerryshao pushed a commit that referenced this issue Jul 31, 2023
…ore (#125)

### What changes were proposed in this pull request?

- Implement interface EntityStore with KvEntityStore
- Implement KvBackend with RocksDBKvBackend

### Why are the changes needed?

Issue #122 has introduced the KvBackend storage interface for entity
storing, but till now, No implementation has been made to implement this
interface. this PR accomplishes KV backend for RocksDB

Fix: #121 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Add UT `TestEntityStorageBackend`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants