Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] add auto_increment field in AddColumn #1793

Closed
yuqi1129 opened this issue Jan 30, 2024 · 5 comments
Closed

[Improvement] add auto_increment field in AddColumn #1793

yuqi1129 opened this issue Jan 30, 2024 · 5 comments
Assignees
Labels
improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

What would you like to be improved?

As we have supported column auto_increment property, we need to add field auto_increment in the AddColumn class.

How should we improve?

No response

@yuqi1129 yuqi1129 added the improvement Improvements on everything label Jan 30, 2024
@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Feb 4, 2024
@SteNicholas
Copy link
Member

SteNicholas commented Feb 7, 2024

@yuqi1129, could this ticket also introduce UpdateColumnAutoIncrement to support auto_increment?
BTW, AddColumn should not only add auto_increment, but also support add index, otherwise the AddColumn could not add auto_increment.

@yuqi1129
Copy link
Contributor Author

@yuqi1129, could this ticket also introduce UpdateColumnAutoIncrement to support auto_increment? BTW, AddColumn should not only add auto_increment, but also support add index, otherwise the AddColumn could not add auto_increment.

I'm sorry for not getting back to you earlier, Nicholas. The scenarios you mentioned should also be taken into consideration.

@Clearvive, as you are knowledgeable and responsible for this point, can you follow up on this issue and its aftermath?

@SteNicholas
Copy link
Member

@Clearvive, any input for above comment?

@Clearvive
Copy link
Contributor

@SteNicholas The logic regarding this area is already under development, and PR will be proposed in the future. You can review it together

@Clearvive Clearvive self-assigned this Feb 27, 2024
@jerryshao
Copy link
Contributor

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
Development

No branches or pull requests

4 participants