Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] missing of conversion in DTOConverters #3903

Closed
xiaozcy opened this issue Jun 19, 2024 · 0 comments · Fixed by #3904
Closed

[Bug report] missing of conversion in DTOConverters #3903

xiaozcy opened this issue Jun 19, 2024 · 0 comments · Fixed by #3904
Assignees
@xiaozcy
Labels
0.6.0 Release v0.6.0 bug Something isn't working

Comments

@xiaozcy
Copy link
Contributor

xiaozcy commented Jun 19, 2024

Version

main branch

Describe what's wrong

In DTOConverters, we try to convert PartitionDTO to Partition, but the literal values of partition are not converted, which makes the literal values are instances of LiteralDTO instead of LiteralImpl.

Error message and/or stacktrace

As mentioned above, this is a code bug.

How to reproduce

N/A

Additional context

No response
@xiaozcy xiaozcy added the bug Something isn't working label Jun 19, 2024
@xiaozcy xiaozcy mentioned this issue Jun 19, 2024
Merged
@mchades mchades added the 0.6.0 Release v0.6.0 label Jun 19, 2024
shaofengshi pushed a commit to shaofengshi/gravitino that referenced this issue Jun 24, 2024
@xiaozcy @shaofengshi
[datastrato#3903] fix(common): convert literal values of partition in…
a534162 
… `DTOConverters` (datastrato#3904)

### What changes were proposed in this pull request?

Convert literal values of partition in `DTOConverters`.

### Why are the changes needed?

Fix: datastrato#3903 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

UT.

Co-authored-by: zhanghan18 <zhanghan18@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaozcy xiaozcy

Labels
0.6.0 Release v0.6.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3903] fix(common): convert literal values of partition in DTOConverters xiaozcy/gravitino
2 participants
@mchades @xiaozcy