[#2436] feat(IT): Add catalogs page to web e2e test #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch3yne
force-pushed
the
add-e2e-catalogs
branch
2 times, most recently
from
9090ba1
to
c107166
Compare
|
@ch3yne Please attach Web page snapshot image in PR, It can help to better review PR. |
xunliu
reviewed
Mar 14, 2024
...on-test/src/test/java/com/datastrato/gravitino/integration/test/web/ui/CatalogsPageTest.java
Outdated
Show resolved
Hide resolved
ch3yne
changed the title
ch3yne
force-pushed
the
add-e2e-catalogs
branch
2 times, most recently
from
afed77a
to
391e4f3
Compare
ch3yne
force-pushed
the
add-e2e-catalogs
branch
10 times, most recently
from
baf66b5
to
7a1bc1c
Compare
ch3yne
force-pushed
the
add-e2e-catalogs
branch
from
7a1bc1c
to
82b2478
Compare
LauraXia123
reviewed
Mar 22, 2024
|
|
||
| Assertions.assertTrue(catalogsPage.verifyCreateHiveCatalog(catalogName)); | ||
| } | ||
|
|
There was a problem hiding this comment.
We can add a test case testCreateMultipleCatalogs and check the render table data is correct values when switch different catalog tree nodes
There was a problem hiding this comment.
Because other providers of catalogs require different environments, I will add these tests in the next pull request.
|
LGTM, Thanks @ch3yne |
LauraXia123
approved these changes
Mar 26, 2024
coolderli
pushed a commit
to coolderli/gravitino
that referenced
this pull request
Apr 2, 2024
…rato#2528) ### What changes were proposed in this pull request? Add catalogs page to web e2e test. - show parent details - create a catalog - view existed catalog details - edit existed catalog - delete existed catalog - link to schemas - link to tables - back to homepage ### Why are the changes needed? Fix: datastrato#2436 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add catalogs page to web e2e test.
Why are the changes needed?
Fix: #2436
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A