[#24] Add metadata connector plugin framework #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? This PR propose the schema and type spec for Unified Catalog. This spec is used to describe how metadata is organized in the system. ### Why are the changes needed? This PR defines the basic metadata schema model, which will be used in the system for memory structure, on-wire protocol and serialization protocol. ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
…ndecy and plugin version (#18) ### What changes were proposed in this pull request? This PR improves the gradle build file to use gradle catalog mechanism to centralize the dependency and plugin versions. Also removes some redundant codes. ### Why are the changes needed? Currently there's no centralized version control place for project, this will easily lead to dependency chaos. After some investigation, we choose to use gradle's default catalog mechanism to manage all the versions in a central place. Fix: #17 ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? Local manual test.
### What changes were proposed in this pull request? This PR proposes to implement the schema metadata and type system in Java and Protobuf. ### Why are the changes needed? This PR defines a core metadata system for unified catalog. ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? This PR adds UT to cover the schema definitions.
…ema (#20) ### What changes were proposed in this pull request? This PR adds JSON serde support for schema system. ### Why are the changes needed? The adds of JSON serde support will help to support REST API for Unified Catalog. Fix: #16 ### Does this PR introduce _any_ user-facing change? NA ### How was this patch tested? And new UTs.
|
@jerryshao Please help me review this PR, Thanks! |
|
I would like to see the design docs first before grabbing a bunch of codes. This seems a like the transplant from metacat, I would suggest thinking of how we achieve this, not just mimicking metacat's way. Besides, the gradle dependency managements and project package name should follow what I did before. Also choosing MySQL to be the implementation should be carefully thought of, I would doubt that MySQL connector may not be so popular compared to HMS or other OLAP systems in Big Data area. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MySqlConnectorPluginTestunit test.Why are the changes needed?
We need to support more data source connectors, Through plugin mode can easily maintain and extend.
Fix: #24
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A