Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3185] fix(doc): Use the iceberg latest version url in doc #3212

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

lw-yang
Copy link
Contributor

@lw-yang lw-yang commented Apr 29, 2024

What changes were proposed in this pull request?

we found the https://iceberg.apache.org/docs/1.3.1/configuration/ url doesn't work, we shoud use the latest version url to avoid this

Why are the changes needed?

Fix: #3185

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A

@yuqi1129 yuqi1129 requested a review from FANNG1 April 29, 2024 06:54
@qqqttt123
Copy link
Contributor

qqqttt123 commented Apr 29, 2024

One point:
It should be consistent with the version which our project used instead of latest version.

@jerryshao
Copy link
Contributor

Do we support newest version of Iceberg @FANNG1 , if not, we'd better not change the document until we support it.

@FANNG1
Copy link
Contributor

FANNG1 commented Apr 29, 2024

Do we support newest version of Iceberg @FANNG1 , if not, we'd better not change the document until we support it.

we support Iceberg 1.3.1 for now, but the 1.3.1 configuration doc is not exists for now.

@jerryshao
Copy link
Contributor

So, we'd better add newer version support before updating the docs.

@FANNG1
Copy link
Contributor

FANNG1 commented Aug 1, 2024

@lw-yang Iceberg in Gravitino is updated to 1.5.2, could you update the PR?

@lw-yang
Copy link
Contributor Author

lw-yang commented Aug 1, 2024

@lw-yang Iceberg in Gravitino is updated to 1.5.2, could you update the PR?

get, i will update it

@FANNG1 FANNG1 merged commit 018b70a into apache:main Aug 1, 2024
13 checks passed
@FANNG1
Copy link
Contributor

FANNG1 commented Aug 1, 2024

@lw-yang , merged to main, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] The link of Iceberg table properties in lakehouse-iceberg-catalog doc is no longer working
4 participants