-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3186] feat(spark-connector): Support Iceberg Spark Procedure #3258
Conversation
Hi @FANNG1 could you help review this pr when you are free? |
ok |
.../src/main/java/com/datastrato/gravitino/spark/connector/iceberg/GravitinoIcebergCatalog.java
Show resolved
Hide resolved
...test/java/com/datastrato/gravitino/integration/test/spark/iceberg/SparkIcebergCatalogIT.java
Outdated
Show resolved
Hide resolved
comments have been addressed. cc @FANNG1 |
.../src/main/java/com/datastrato/gravitino/spark/connector/iceberg/GravitinoIcebergCatalog.java
Outdated
Show resolved
Hide resolved
LGTM except two comments |
@caican00 could you rebase with lattest code? |
building failed as
|
It is already the latest code |
let's wait #3424 to be merged. |
@FANNG1 could you please help re-trigger the pipeline? thank you. |
### What changes were proposed in this pull request? Support Iceberg Spark Procedure. ### Why are the changes needed? Support manage Iceberg metadata using Spark SQL. Fix: #3186 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New ITs.
@caican00 ,merged in main, thanks for your work |
…pache#3258) ### What changes were proposed in this pull request? Support Iceberg Spark Procedure. ### Why are the changes needed? Support manage Iceberg metadata using Spark SQL. Fix: apache#3186 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New ITs.
What changes were proposed in this pull request?
Support Iceberg Spark Procedure.
Why are the changes needed?
Support manage Iceberg metadata using Spark SQL.
Fix: #3186
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New ITs.