-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3319] fix(PyClient): ./gradlew test -PskipITs failed in python-client #3322
Conversation
from gravitino.dto.responses.metalake_response import MetalakeResponse | ||
|
||
|
||
class TestMetalakeUT(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we already have two different folders for UT and IT, I think it is not necessary to add "UT" as a suffix, "TestMetalake" should be enough, WDYT? @xunliu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
…nt (#3322) ### What changes were proposed in this pull request? 1. Add `skipITs` build params in the Python Client Gradle script. 2. Use different directory storage integration test and unit tests. ### Why are the changes needed? When running this command ./gradlew test -PskipITs directly. the Gradle python test task will be failed because of lacking compileDistribution step. we should fix it to make all the commands work. Fix: #3319 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI Passed
…n-client (apache#3322) ### What changes were proposed in this pull request? 1. Add `skipITs` build params in the Python Client Gradle script. 2. Use different directory storage integration test and unit tests. ### Why are the changes needed? When running this command ./gradlew test -PskipITs directly. the Gradle python test task will be failed because of lacking compileDistribution step. we should fix it to make all the commands work. Fix: apache#3319 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI Passed
What changes were proposed in this pull request?
skipITs
build params in the Python Client Gradle script.Why are the changes needed?
When running this command ./gradlew test -PskipITs directly. the Gradle python test task will be failed because of lacking compileDistribution step. we should fix it to make all the commands work.
Fix: #3319
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI Passed