[#3319] fix(PyClient): ./gradlew test -PskipITs failed in python-client #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
May 10, 2024
| from gravitino.dto.responses.metalake_response import MetalakeResponse | ||
|
|
||
|
|
||
| class TestMetalakeUT(unittest.TestCase): |
There was a problem hiding this comment.
Since we already have two different folders for UT and IT, I think it is not necessary to add "UT" as a suffix, "TestMetalake" should be enough, WDYT? @xunliu
jerryshao
approved these changes
May 11, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 11, 2024
…nt (#3322) ### What changes were proposed in this pull request? 1. Add `skipITs` build params in the Python Client Gradle script. 2. Use different directory storage integration test and unit tests. ### Why are the changes needed? When running this command ./gradlew test -PskipITs directly. the Gradle python test task will be failed because of lacking compileDistribution step. we should fix it to make all the commands work. Fix: #3319 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI Passed
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…n-client (apache#3322) ### What changes were proposed in this pull request? 1. Add `skipITs` build params in the Python Client Gradle script. 2. Use different directory storage integration test and unit tests. ### Why are the changes needed? When running this command ./gradlew test -PskipITs directly. the Gradle python test task will be failed because of lacking compileDistribution step. we should fix it to make all the commands work. Fix: apache#3319 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI Passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
skipITsbuild params in the Python Client Gradle script.Why are the changes needed?
When running this command ./gradlew test -PskipITs directly. the Gradle python test task will be failed because of lacking compileDistribution step. we should fix it to make all the commands work.
Fix: #3319
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI Passed