Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1573] feat(spark-connector): Spark regression test system #3933

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FANNG1
Copy link
Contributor

@FANNG1 FANNG1 commented Jun 21, 2024

What changes were proposed in this pull request?

add Spark regression test system to do Regression test for SparkSQL.

Why are the changes needed?

Fix: #1573

Does this PR introduce any user-facing change?

no

How was this patch tested?

add IT

@FANNG1 FANNG1 marked this pull request as draft June 21, 2024 03:34
@FANNG1 FANNG1 force-pushed the r-test branch 10 times, most recently from b64bbd7 to 27dcee6 Compare June 26, 2024 14:22
@FANNG1 FANNG1 changed the title [SIP] Spark Regression test [#1573] feat(spark-connector): Spark regression test system Jun 27, 2024
@FANNG1 FANNG1 marked this pull request as ready for review June 27, 2024 01:08
@FANNG1
Copy link
Contributor Author

FANNG1 commented Jun 27, 2024

@yuqi1129 @diqiu50 @jerryshao @qqqttt123 , please help to review when you free, thanks

@diqiu50
Copy link
Contributor

diqiu50 commented Jun 27, 2024

What changes were proposed in this pull request?

add Spark regression test system to do Regression test for SparkSQL.

Why are the changes needed?

Fix: #1573

Does this PR introduce any user-facing change?

no

How was this patch tested?

add IT

The links are not accessed

@FANNG1
Copy link
Contributor Author

FANNG1 commented Jun 27, 2024

What changes were proposed in this pull request?

add Spark regression test system to do Regression test for SparkSQL.

Why are the changes needed?

Fix: #1573

Does this PR introduce any user-facing change?

no

How was this patch tested?

add IT

The links are not accessed

I could access the links, which links are not accessed? could you try again?

queries = splitWithSemicolon(queries);
queries = cleanAndFilterQueries(queries);
return queries;
}
Copy link
Contributor

@diqiu50 diqiu50 Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the test system only used in the docker gravitino and local spark environment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR yes, we could extend it in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] [spark-connector] setup a test system to cover existings spark&hive sql tests
2 participants