[#86] refactor(catalog): Change the Namespace semantics to Schema in catalog definition
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xunliu please take time to review this PR, I changed the semantics a bit. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to change
SupportNamespacestoSupportSchemas, and introducesSchema(aka. database) terminology to Graviton's catalog system.Also, this PR refactors the current
HiveCataloga bit to suit the new interface.Why are the changes needed?
As mentioned in #86 , the current
Namespacein Graviton has two meanings, which may be confusing for developers.NamespaceinNameIdentiferdefines the name prefix of an identifier, for example, a catalog "metalake.catalog" hasNamespace"metalake".SupportNamepacesmainly stands for database, or the entity repository under catalog, which differs from the thing mentioned in No.1.So here we propose a change to the current definitions to make them more distinguishable.
Fix: #86
Does this PR introduce any user-facing change?
Introduce new
SupportSchemasinterfaces and remove theSupportNamespaces.How was this patch tested?
Existing UTs.