removed csrf check for instagram v2 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustinas
suggested changes
Apr 14, 2020
whiteshadow-gr
force-pushed
the
instagram-v2
branch
from
b0417d5
to
0bd50e8
Compare
augustinas
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instagram was failing authorization, both for v1 and v2 APIs, with a Bad Signature error. After a thorough research
we identified that the problem lies in the
stateparameter and how Silhouette and Instagram form and parse it.Specifically the
stateparameter Silhouette is sending, not only to instagram but on all social providers, has thefollowing format: `1-signature-data==-HAT token== example:
[DEBUG] [2020-04-07 22:44:46] c.h.d.u.ImprovedJcaSigner - State parameter is 1-1dd74ac1125e19d8de39fa4afb7ad44ad8a9798c-Y3NyZi1zdGF0ZQ%3D%3D-eyJ0b2tlbiI6IjE5ZjNjMjQ3NDE0NWQyZGQxMmIyODljNjU5ZDNhYWU2ZDk2OWE1N2UzNDAxMzM1YmY3ZjEwNWE2YzU3YzJiOGEwOGIzNzE5MTlhNTEzZTZiNmUxZTYxZjExMGI1MDJiNjJiZDMwNjQ1NzBhZjM5ZDYyNzBhMWUwMmE3NzQxOGVhMTA0NDQ0NGY4YWQxYjc0ZDRiMjdlM2RiNDRiN2JkY2IwMTI4NjFkMWYwMzIwNWI5OGNjNjdhZTdmMmZlMTVhYzJmNjU0YzE1Y2U4NTVhYTMwMDY3MWQ5MDdlMmE2NzhmNzFkNmVlZTU0NTIyMjZkNWY2NzAxMTUwY2M5NmEwNWIifQ%3D%3DInstagram by default removes the token, because of the = character. Upon successful authorization the
stateparameter returned by Instagram has been stripped from the token. This results in the signatures between what the Data Plug sent and what Instagram returns to be different and as a result Silhouette throws the Bad Signature error. To test that it's indeed the = character that is causing the issues we replaced the == with __ just before the redirect to instagram happens. As expected, Instagram is not removing the token in this case. In this case, thestateparameter has been modified and us a result we weren't able to pass the validation step once again. Removing the token entirely has another effect down the line, Silhouette is not able to identify which user connected the Data Plug and it throws another exception this time.As a result we concluded to disable the CSRF check for the time being. Also filled a bug report to Facebook that's currently under investigation.
Issue reported to Facebook: https://developers.facebook.com/support/bugs/511886289481673/