Support file path glob pattern #5
Conversation
victowang
force-pushed
the
support-file-path-glob
branch
2 times, most recently
from
43472a1
to
f548d0b
Compare
victowang
force-pushed
the
support-file-path-glob
branch
from
f548d0b
to
d3132e6
Compare
|
Main file to review is main.ts |
victowang
force-pushed
the
support-file-path-glob
branch
from
d391c5e
to
0ddbc5e
Compare
victowang
force-pushed
the
support-file-path-glob
branch
from
0ddbc5e
to
d24b82f
Compare
| } | ||
| console.log("Found files matching path: " + input_binary_path); | ||
| console.log(files); | ||
| // Upload all the files that matched the file path |
There was a problem hiding this comment.
I think this could be a problem (uploading multiple files), but not sure?
There was a problem hiding this comment.
Maybe we should add a limit of 2 or 3?
There was a problem hiding this comment.
Uploading only 2 or 3 out of (many) is not ideal because there is no way to control which of the (many) files get uploaded.
I think we should either error out if more than one file is matched, or upload 'em all. I vote to leave it as is. That way it is possible to build multiple apps off the same code base and upload them all with one call to the plugin.
| } | ||
| // retry upload 3 times |
There was a problem hiding this comment.
There are two instances of this code in the PR (the "retry upload 3 times" logic); we should only have one, I think?
There was a problem hiding this comment.
you were confused i think by the fact that there is a ts and js file. However it is only present once in the TS file (and a second time on the generated js code)
main.ts
Outdated
| "Did not find any files that match path:" + input_binary_path | ||
| ); | ||
| } | ||
| console.log("Found files matching path: " + input_binary_path); |
Make the
UPLOAD_BINARY_PATHinput support path globs, like./app/build/outputs/apk/debug/*.apk