Add python pre-req and quotes for mac curl #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: steve lasker <stevenlasker@hotmail.com>
|
I noticed that some of the other API reference pages have a mixture of curl examples with quotes and others without quotes. Both work on git bash so I'm thinking that we should make it standard to use quotes. Does that sound like a good idea? |
|
One more thing, the other curl examples in the page do not have quotes. Do they all work on a MAC? |
|
+1 for consistency. |
|
I know that Madia and Rusty have MACs. There might be others, possibly John Hartley. |
|
I have an old Mac I can try and revive going forward. For the sake of expediency, can we merge this one as we know this fixes the current issues @beekman33 hit, and make additional consistency fixes as a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@beekman33 noticed the url for the events API didn't work on a mac. Enclosing with quotes worked.
We also added a generic link to the python dependency.