Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a lot of old stuff #9

Merged
merged 2 commits into from Aug 15, 2015
Merged

Fix a lot of old stuff #9

merged 2 commits into from Aug 15, 2015

Conversation

ghost
Copy link

@ghost ghost commented Aug 6, 2015

Replaced old, unsupported and/or deprecated stuff with new stuff.
#1 #2 #3 #4 #5 #6 #7

@dataviruset

@DorCoMaNdO
Copy link
Collaborator

Please revert the workaround for the USP in CS:GO, your current code is only viable for the CT side and covers only the USP while there are other weapons causing issues.
I have a code I made a while ago for a private project of mine, I'll make some adjustments and submit it when I get some time to work on it.

@ghost
Copy link
Author

ghost commented Aug 6, 2015

I know, but all reported crash bugs are with this reason. So I think this enough.

@dataviruset
Copy link
Owner

Maybe I should've mentioned it before, but it would be great if you could split everything up into many commits, one for every feature or small adjustment, instead of having one commit for a lot of things. That way it's easier to track what changed and which code changes are connected to each other. If you think it will be too much hassle, we can accept it like this for this time, though.

@ghost
Copy link
Author

ghost commented Aug 6, 2015

@dataviruset Ok, after that.

@DorCoMaNdO btw. We can add this nowm because it's only an workaround. You can change it at any time.

@dataviruset
Copy link
Owner

I know that @DorCoMaNdO might disagree, but I think @bara20's fix is good enough for now, we can always make it better later :)

@ghost ghost mentioned this pull request Aug 6, 2015
@ovo4096
Copy link
Contributor

ovo4096 commented Aug 6, 2015

GetClientAuthId may not work at SM 1.5.0

@ghost
Copy link
Author

ghost commented Aug 6, 2015

And? SM1.5 and SM1.6 are unsupported. Current stable release is 1.7.2 ( https://wiki.alliedmods.net/SourceMod_1.7.2_Release_Notes ), so why support for sm1.6 and/or lower?
Here is a list of supported versions: http://www.sourcemod.net/snapshots.php

@ovo4096
Copy link
Contributor

ovo4096 commented Aug 6, 2015

I see the introduction, this plugin is Requirements: SourceMod 1.5.0+.

'void' is not a Pawn type. :3

@ghost
Copy link
Author

ghost commented Aug 6, 2015

https://wiki.alliedmods.net/SourcePawn_Transitional_Syntax

I'll change the requirements.

@ovo4096
Copy link
Contributor

ovo4096 commented Aug 6, 2015

:3 I think it is better supported SM 1.5.0.

@ghost
Copy link
Author

ghost commented Aug 6, 2015

No, sourcemod 1.5 is a unsupported version (https://github.com/alliedmodders/sourcemod/tree/1.5-dev last commit 2014...) and sourcemod 1.6 (https://github.com/alliedmodders/sourcemod/tree/1.6-dev last commit february 2015...).

But that's a decision for @dataviruset

@ovo4096
Copy link
Contributor

ovo4096 commented Aug 6, 2015

Ah, You're right.

@ghost
Copy link
Author

ghost commented Aug 13, 2015

?
@dataviruset

dataviruset added a commit that referenced this pull request Aug 15, 2015
Merges fixes by Bara20

Rewrites CS:GO sound emitting to use EmitSoundAny include
Removes FCVAR_PLUGIN from convars as it's obsolete
Changes game (CS:S/CS:GO) detection method
Renews plugin syntax according to SourcePawn new transitional syntax
Bumps up SourceMod version requirement to 1.7.0+
Replaces SteamTools extension with SteamWorks
Explicitly uses Steam2 auth ID when banning players
Fixes invalid entity issue in Gun Toss
@dataviruset dataviruset merged commit 75a0c6e into dataviruset:master Aug 15, 2015
@ghost ghost deleted the fixes branch December 25, 2015 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants