Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isDialogOpen in trackRanking function has inconsistent state when switching between dialog actions #761

Open
kirangadhave opened this issue Jul 28, 2022 · 0 comments
Labels
type: bug Something isn't working

Comments

@kirangadhave
Copy link

kirangadhave commented Jul 28, 2022

Steps to reproduce

  1. Open the lineup column dialog box
  2. Switch between different options like filtering, sorting, etc.
  3. The clue wrapper will set the isDialogOpen to close, even though the dialog is still open.

Observed behavior

  • Any unexpected output or action (or lack of expected output or action)
    After switching between dialog options, clue stops buffering the live preview actions.

  • Static or animated images showing the UI behavior
    screen-recorder-thu-jul-28-2022-11-18-56.webm

Expected behavior

  • clue wrapper should not change isDialogOpen until the close or confirm button is clicked and the dialog has closed.

This can potentially be a lineup issue. Lineup shouldn't trigger the DIALOG_CLOSE event till the dialog actually closes.

@kirangadhave kirangadhave added the type: bug Something isn't working label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant