feat: add pathway and protein entity colors #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdanielamoitzi
requested review from
thinkh,
dg-datavisyn,
puehringer and
dvchristianbors
dvchristianbors
approved these changes
Apr 11, 2024
thinkh
approved these changes
Apr 11, 2024
Merged
puehringer
added a commit
that referenced
this pull request
Apr 23, 2024
* add new cell line color * blubb * chore: prepare next dev release * update gene and chem structure ic ons * prepare next dev version * feat: add pathway and protein entity colors (#256) * fix: fix viewbox of custom icons (#254) * add css support for custom icons * add support for entity icons * export function to inject css for custom icons * fix viewbox for icons and center them * add export for icon utils * remove inject from main app * remove icons from main app * remove css class injection * test: use app shell instead of body in cypress test (#258) use app shell instead of body * prepare release 9.2.2 --------- Co-authored-by: Daniela <daniela.moitzi@datavisyn.io> Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: dvdanielamoitzi <57343176+dvdanielamoitzi@users.noreply.github.com> Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 new entity colors: Pathways (pink) and Proteins (light blue). The screenshots show how those would look like in Ordino workbenches:
Pathways:
Proteins:
Thanks for creating this pull request 🤗