Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthService configuration issues should not be ignored #1082

Closed
n1koo opened this issue Jan 5, 2019 · 3 comments
Closed

AuthService configuration issues should not be ignored #1082

n1koo opened this issue Jan 5, 2019 · 3 comments
Labels
stale Issue is stale and will be closed

Comments

@n1koo
Copy link
Contributor

n1koo commented Jan 5, 2019

Please describe your use case / problem.
If there is a configured AuthService that has a config issue (eg. missing value), Ambassador should die, not just ignore the specification.

Ignoring it means you will rather open the door and than lock if the lock is broken.

For example people hitting: #1058 would see this behaviour of opening their service to the world.

Describe the solution you'd like
If there is a config problem with the AuthService its better to stop processing and panic.

@stale
Copy link

stale bot commented Jun 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Jun 5, 2019
@n1koo
Copy link
Contributor Author

n1koo commented Jun 5, 2019

This is still valid I think?

@stale stale bot removed the stale Issue is stale and will be closed label Jun 5, 2019
@stale
Copy link

stale bot commented Aug 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Aug 4, 2019
@stale stale bot closed this as completed Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue is stale and will be closed
Projects
None yet
Development

No branches or pull requests

1 participant