Add a bunch of tests, fixing a bunch of issues #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
This reverts commit 8f44d44. Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
LukeShu
force-pushed
the
lukeshu/tests
branch
from
7ffcabe
to
9a3f29b
Compare
5 tasks
thallgren
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
This all looks good to me, but I wonder if we also need an escape hatch to keep our CI-builds from being blocked between the time a problem is discovered and this component is updated to handle it.
What about this:
- A yaml-file where the info that
go-mkopensourceemits for a component can be added manually. go-mkopensourcereads that file, and if an entry is found for a component which is problematic, it uses that entry instead of erroring.- If an entry is found for a component that is resolved successfully, then it errors out with a message indicating that the manual entry is obsolete and must be removed.
This solution would give us full control while at the same time force us to keep the manual list to an absolute minimum.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some trouble with go-mkopensource when upgrading Emissary to Go 1.17, and I know Thomas had been having some trouble with it when upgrading Kubernetes. So I just started hammering on it, not just fixing issues, but writing testcases. And I ended up looking at Telepresence, because Telepresence has a lot simpler of a
go.mod, so it was easier to isolate issues to write testcases.As usual, I suggest a commit-by-commit review. This PR looks huge, but that's because it's adding gobs of tests; the diffstat of the code-under-test is more like a much more reasonable +300/-150.