Upgrade client-go 11.0.0→11.0.0+patches, consul 1.4.4→1.5.0 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Edit ./pkg/consulwatch/*.go
to use github.com/hashicorp/consul/api/watch
instead of github.com/hashicorp/consul/watch
2. Edit ./pkg/k8s/client.go to do an anonymous import of
github.com/datawire/libk8s.
3. Remove the k8s.io "replace" lines from go.mod
4. Run:
go mod edit \
-require=github.com/hashicorp/consul@v1.5.0 \
-require=github.com/hashicorp/consul/api@v1.1.0 \
-require=github.com/hashicorp/consul/sdk@v0.1.1 \
LukeShu
force-pushed
the
lukeshu/libk8s
branch
from
5076727
to
e62e80e
Compare
We no longer have a dependency that tries to bring in the problematic version.
ark3
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back, I tried upgrading client-go to v12 (kube 1.15) in teleproxy.git, mostly just as an exercise to see how difficult it would be, not because I actually wanted to switch to v12. I failed to do it, and ended up in dependency hell. I came to the conclusion that trying to manage client-go's dependencies and your own dependencies at the same time was a nightmare, and that it would be a good idea to have a separate library just to isolate the dependencies of client-go.
I made that library! https://github.com/datawire/libk8s. Currently, it does nothing but anonymous-import every part of client-go, and properly declare all of the versions of dependencies.
Also, we'd been using the
v11.0.0tag ofclient-go. Did you know that there's arelease-11.0branch that gets bug-fixes and security fixes!?OK, so this PR is about equal parts of several things:
release-11.0branch)go mod tidywas breaking the build (answer: consul)