Skip to content

Commit

Permalink
Fix some locale jsdocs (typos, corrections, make @summary unique)
Browse files Browse the repository at this point in the history
  • Loading branch information
fturmel committed Dec 11, 2021
1 parent 803cbdd commit 20963fe
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
6 changes: 3 additions & 3 deletions src/locale/ar-SA/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import match from './_lib/match/index'
/**
* @type {Locale}
* @category Locales
* @summary Arabic locale (Sauid Arabic).
* @summary Arabic locale (Saudi Arabic).
* @language Arabic
* @iso-639-2 ara
* @author Dhaifallah Alwadani [@dalwadani]{@link https://github.com/dalwadani}
Expand All @@ -21,8 +21,8 @@ var locale = {
match: match,
options: {
weekStartsOn: 0 /* Sunday */,
firstWeekContainsDate: 1
}
firstWeekContainsDate: 1,
},
}

export default locale
4 changes: 2 additions & 2 deletions src/locale/ar/index.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import type { Locale } from '../types'
import formatDistance from './_lib/formatDistance/index'
import formatLong from './_lib/formatLong/index'
import formatRelative from './_lib/formatRelative/index'
import localize from './_lib/localize/index'
import match from './_lib/match/index'
import type { Locale } from '../types'

/**
* @type {Locale}
* @category Locales
* @summary Arabic locale (Modern Standard Arabic - Al-fussha).
* @summary Arabic locale (Modern Standard Arabic - Al-fusha).
* @language Modern Standard Arabic
* @iso-639-2 ara
* @author Abdallah Hassan [@AbdallahAHO]{@link https://github.com/AbdallahAHO}
Expand Down
8 changes: 4 additions & 4 deletions src/locale/nl-BE/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import match from './_lib/match/index'
/**
* @type {Locale}
* @category Locales
* @summary Dutch locale.
* @language Dutch
* @summary Flemish locale (Belgium).

This comment has been minimized.

Copy link
@bartduisters

bartduisters Dec 11, 2021

This is just incorrect.

Belgium has three official languages: Dutch, French and German. In Flanders, the northern part of Belgium, people speak Dutch. Most of the time, this variant of Dutch is called Flemish.

It was correct before the change. If it needs to be more specific it could be:

@summary Dutch (Belgium) locale.
@language Dutch (Belgium)
* @language Flemish
* @iso-639-2 nld
* @author Jorik Tangelder [@jtangelder]{@link https://github.com/jtangelder}
* @author Ruben Stolk [@rubenstolk]{@link https://github.com/rubenstolk}
Expand All @@ -24,8 +24,8 @@ var locale = {
match: match,
options: {
weekStartsOn: 1 /* Monday */,
firstWeekContainsDate: 4
}
firstWeekContainsDate: 4,
},
}

export default locale
6 changes: 3 additions & 3 deletions src/locale/zh-CN/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import match from './_lib/match/index'
/**
* @type {Locale}
* @category Locales
* @summary Chinese Simplified locale.
* @summary Chinese Simplified locale (Mainland China).
* @language Chinese Simplified
* @iso-639-2 zho
* @author Changyu Geng [@KingMario]{@link https://github.com/KingMario}
Expand All @@ -25,8 +25,8 @@ var locale = {
match: match,
options: {
weekStartsOn: 1 /* Monday */,
firstWeekContainsDate: 4
}
firstWeekContainsDate: 4,
},
}

export default locale
2 changes: 1 addition & 1 deletion src/locale/zh-HK/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import match from './_lib/match/index'
/**
* @type {Locale}
* @category Locales
* @summary Chinese Traditional locale.
* @summary Chinese Traditional locale (Hong Kong).
* @language Chinese Traditional
* @iso-639-2 zho
* @author Gary Ip [@gaplo]{@link https://github.com/gaplo}
Expand Down
6 changes: 3 additions & 3 deletions src/locale/zh-TW/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import match from './_lib/match/index'
/**
* @type {Locale}
* @category Locales
* @summary Chinese Traditional locale.
* @summary Chinese Traditional locale (Taiwan).
* @language Chinese Traditional
* @iso-639-2 zho
* @author tonypai [@tpai]{@link https://github.com/tpai}
Expand All @@ -23,8 +23,8 @@ var locale = {
match: match,
options: {
weekStartsOn: 1 /* Monday */,
firstWeekContainsDate: 4
}
firstWeekContainsDate: 4,
},
}

export default locale

0 comments on commit 20963fe

Please sign in to comment.