Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose module field in package.json #414

Closed
tunnckoCore opened this issue Jan 21, 2017 · 2 comments
Closed

Expose module field in package.json #414

tunnckoCore opened this issue Jan 21, 2017 · 2 comments
Labels
⚙️ Chore 🤹‍♂️ Support

Comments

@tunnckoCore
Copy link
Member

tunnckoCore commented Jan 21, 2017 •
edited

To support sane modern es6 aware bundlers do their job better.

ref: https://github.com/rollup/rollup/wiki/pkg.module
(there was some wiki page that explain few variants and why they are rejected but can't find it)

ooh, found it: https://github.com/nodejs/node/wiki/ES6-Module-Detection-in-Node, specifically https://github.com/nodejs/node/wiki/ES6-Module-Detection-in-Node#option-4-meta-in-packagejson. It is "rejected" but is best working approach currently and is used by Webpack and Rollup
@leshakoss
Copy link
Contributor

@tunnckoCore work in progress: https://github.com/date-fns/date-fns/pull/404/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R13

leshakoss added a commit that referenced this issue Feb 11, 2017
@leshakoss
ES Modules (closes #179, closes #414) (#404)
7816837 
* Converts to ES6 to enable tree-shaking

* Updates index.js to ES6

* Adds `babel-plugin-add-module-exports` for backward compatibility

* Modify index.js generator

* Convert functions to es6 import/export format

* Add examples

* Update stuff

* Update webpack 2.0 in examples

* Install gzip-size-cli and pretty-bytes-cli to examples

* Fix browserify example

* Update examples READMEs

* Move build-index at the end of release.sh

* Add names in jsDocs

* Fix build-docs

* Regenerate docs

* Add smoke test

* Rebuild index.js

* Fix version of phantomjs

* Add more examples

* Modify flow typings generator to include aliases in all typings

* Modify build_index to generate es and non-es indices

* Generate TypeScript typings for es
leshakoss added a commit that referenced this issue Feb 13, 2017
@leshakoss
ES Modules (closes #179, closes #414) (#404)
c3067b4 
* Converts to ES6 to enable tree-shaking

* Updates index.js to ES6

* Adds `babel-plugin-add-module-exports` for backward compatibility

* Modify index.js generator

* Convert functions to es6 import/export format

* Add examples

* Update stuff

* Update webpack 2.0 in examples

* Install gzip-size-cli and pretty-bytes-cli to examples

* Fix browserify example

* Update examples READMEs

* Move build-index at the end of release.sh

* Add names in jsDocs

* Fix build-docs

* Regenerate docs

* Add smoke test

* Rebuild index.js

* Fix version of phantomjs

* Add more examples

* Modify flow typings generator to include aliases in all typings

* Modify build_index to generate es and non-es indices

* Generate TypeScript typings for es
leshakoss added a commit that referenced this issue Feb 28, 2017
@leshakoss
ES Modules (closes #179, closes #414) (#404)
852856b 
* Converts to ES6 to enable tree-shaking

* Updates index.js to ES6

* Adds `babel-plugin-add-module-exports` for backward compatibility

* Modify index.js generator

* Convert functions to es6 import/export format

* Add examples

* Update stuff

* Update webpack 2.0 in examples

* Install gzip-size-cli and pretty-bytes-cli to examples

* Fix browserify example

* Update examples READMEs

* Move build-index at the end of release.sh

* Add names in jsDocs

* Fix build-docs

* Regenerate docs

* Add smoke test

* Rebuild index.js

* Fix version of phantomjs

* Add more examples

* Modify flow typings generator to include aliases in all typings

* Modify build_index to generate es and non-es indices

* Generate TypeScript typings for es
leshakoss added a commit that referenced this issue Mar 28, 2017
@leshakoss
ES Modules (closes #179, closes #414) (#404)
9221d82 
* Converts to ES6 to enable tree-shaking

* Updates index.js to ES6

* Adds `babel-plugin-add-module-exports` for backward compatibility

* Modify index.js generator

* Convert functions to es6 import/export format

* Add examples

* Update stuff

* Update webpack 2.0 in examples

* Install gzip-size-cli and pretty-bytes-cli to examples

* Fix browserify example

* Update examples READMEs

* Move build-index at the end of release.sh

* Add names in jsDocs

* Fix build-docs

* Regenerate docs

* Add smoke test

* Rebuild index.js

* Fix version of phantomjs

* Add more examples

* Modify flow typings generator to include aliases in all typings

* Modify build_index to generate es and non-es indices

* Generate TypeScript typings for es
leshakoss added a commit that referenced this issue Apr 14, 2017
@leshakoss
ES Modules (closes #179, closes #414) (#404)
19ed0c0 
* Converts to ES6 to enable tree-shaking

* Updates index.js to ES6

* Adds `babel-plugin-add-module-exports` for backward compatibility

* Modify index.js generator

* Convert functions to es6 import/export format

* Add examples

* Update stuff

* Update webpack 2.0 in examples

* Install gzip-size-cli and pretty-bytes-cli to examples

* Fix browserify example

* Update examples READMEs

* Move build-index at the end of release.sh

* Add names in jsDocs

* Fix build-docs

* Regenerate docs

* Add smoke test

* Rebuild index.js

* Fix version of phantomjs

* Add more examples

* Modify flow typings generator to include aliases in all typings

* Modify build_index to generate es and non-es indices

* Generate TypeScript typings for es
leshakoss added a commit that referenced this issue May 20, 2017
@leshakoss
ES Modules (closes #179, closes #414) (#404)
9b285f3 
* Converts to ES6 to enable tree-shaking

* Updates index.js to ES6

* Adds `babel-plugin-add-module-exports` for backward compatibility

* Modify index.js generator

* Convert functions to es6 import/export format

* Add examples

* Update stuff

* Update webpack 2.0 in examples

* Install gzip-size-cli and pretty-bytes-cli to examples

* Fix browserify example

* Update examples READMEs

* Move build-index at the end of release.sh

* Add names in jsDocs

* Fix build-docs

* Regenerate docs

* Add smoke test

* Rebuild index.js

* Fix version of phantomjs

* Add more examples

* Modify flow typings generator to include aliases in all typings

* Modify build_index to generate es and non-es indices

* Generate TypeScript typings for es
leshakoss added a commit that referenced this issue May 20, 2017
@leshakoss
ES Modules (closes #179, closes #414) (#404)
fd44545 
* Converts to ES6 to enable tree-shaking

* Updates index.js to ES6

* Adds `babel-plugin-add-module-exports` for backward compatibility

* Modify index.js generator

* Convert functions to es6 import/export format

* Add examples

* Update stuff

* Update webpack 2.0 in examples

* Install gzip-size-cli and pretty-bytes-cli to examples

* Fix browserify example

* Update examples READMEs

* Move build-index at the end of release.sh

* Add names in jsDocs

* Fix build-docs

* Regenerate docs

* Add smoke test

* Rebuild index.js

* Fix version of phantomjs

* Add more examples

* Modify flow typings generator to include aliases in all typings

* Modify build_index to generate es and non-es indices

* Generate TypeScript typings for es
@tunnckoCore
Copy link
Member Author

Cool! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚙️ Chore 🤹‍♂️ Support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leshakoss @tunnckoCore