-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove exception from isValid
#440
Labels
Milestone
Comments
Not checking the type is fine and all, but returning false makes a heck of a lot more sense than exploding with an exception. Shouldn't an isValid check tell you a string isn't a date, not throw an error? isValid('puu') //=> explodes
// so to actually check if that's valid I guess we'd have to do something like...
let valid = false
try {
valid = isValid('puu')
} catch () {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See #389
The text was updated successfully, but these errors were encountered: