Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CA spelling errors and update following official gramatical rules #1289

Merged
merged 1 commit into from
Aug 16, 2019
Merged

fix CA spelling errors and update following official gramatical rules #1289

merged 1 commit into from
Aug 16, 2019

Conversation

avizcaino
Copy link
Contributor

I've updated catalan locale with some gramatical corrections and following official gramatical rules.

@avizcaino
Copy link
Contributor Author

Seems there is a problem with the Coverage report stage on Travis. I reopen #1079 for further investigation.

@kossnocorp kossnocorp added this to the Next release milestone Aug 15, 2019
Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you a lot for making it better. cc @date-fns/i18n-ca

@kossnocorp
Copy link
Member

I'll leave it open for some time in case others would have any comments. If there are no comments or everything's fine, I'll merge and ship it later today or this week.

@avizcaino
Copy link
Contributor Author

Great!

@kossnocorp kossnocorp merged commit 96d2d7b into date-fns:master Aug 16, 2019
@avizcaino avizcaino deleted the ca-spelling-corrections branch August 16, 2019 12:08
@kossnocorp
Copy link
Member

Thank you again, I've shipped this PR as v2.0.0-beta.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants