Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix differenceInMonths #2185

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Fix differenceInMonths #2185

merged 2 commits into from
Feb 5, 2021

Conversation

tan75
Copy link
Contributor

@tan75 tan75 commented Feb 3, 2021

To make this function cater for:

  • end of February dates
  • cases with 1 full calendar month if the end of month of the left date is bigger than the end of month of the right date

To make this function cater for:
- end of February dates
- cases with 1 full calendar month if the end of month of the left date is bigger than the end of month of the right date
Copy link
Member

@kossnocorp kossnocorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between addMonths & differenceInMonths for February dates
2 participants